Patchew URL: https://patchew.org/QEMU/20190612115939.23825-1-shmuel.eider...@oracle.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [SeaBIOS] [QEMU] [PATCH v2 0/8] Add Qemu to SeaBIOS LCHS interface Type: series Message-id: 20190612115939.23825-1-shmuel.eider...@oracle.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190612115939.23825-1-shmuel.eider...@oracle.com -> patchew/20190612115939.23825-1-shmuel.eider...@oracle.com Switched to a new branch 'test' bdf6a1bd24 hd-geo-test: Add tests for lchs override d7b67f4193 bootdevice: FW_CFG interface for LCHS values 11a64fd11f bootdevice: Refactor get_boot_devices_list dce31cf2c7 bootdevice: Gather LCHS from all relevant devices aaa025aea3 scsi: Propagate unrealize() callback to scsi-hd ba777cd8b1 bootdevice: Add interface to gather LCHS ed9b61ee8d block: Support providing LCHS from user eb61f6f1d3 block: Refactor macros - fix tabbing === OUTPUT BEGIN === 1/8 Checking commit eb61f6f1d35c (block: Refactor macros - fix tabbing) ERROR: Macros with complex values should be enclosed in parenthesis #55: FILE: include/hw/block/block.h:65: +#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \ + DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \ + DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \ DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0) total: 1 errors, 0 warnings, 37 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit ed9b61ee8dbf (block: Support providing LCHS from user) 3/8 Checking commit ba777cd8b1e3 (bootdevice: Add interface to gather LCHS) 4/8 Checking commit aaa025aea333 (scsi: Propagate unrealize() callback to scsi-hd) 5/8 Checking commit dce31cf2c7ac (bootdevice: Gather LCHS from all relevant devices) 6/8 Checking commit 11a64fd11f0f (bootdevice: Refactor get_boot_devices_list) 7/8 Checking commit d7b67f4193ef (bootdevice: FW_CFG interface for LCHS values) 8/8 Checking commit bdf6a1bd24bd (hd-geo-test: Add tests for lchs override) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190612115939.23825-1-shmuel.eider...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
