On Mon, Jun 10, 2019 at 07:19:02PM +0530, Aarushi Mehta wrote: > @@ -294,6 +302,7 @@ LuringState *luring_init(Error **errp) > int rc; > LuringState *s; > s = g_malloc0(sizeof(*s)); > + trace_luring_init_state((void *)s, sizeof(*s));
In C conversion to void * is automatic and doesn't need to be done manually. > diff --git a/block/trace-events b/block/trace-events > index eab51497fc..c4564dcd96 100644 > --- a/block/trace-events > +++ b/block/trace-events > @@ -60,6 +60,14 @@ qmp_block_stream(void *bs, void *job) "bs %p job %p" > file_paio_submit(void *acb, void *opaque, int64_t offset, int count, int > type) "acb %p opaque %p offset %"PRId64" count %d type %d" > file_copy_file_range(void *bs, int src, int64_t src_off, int dst, int64_t > dst_off, int64_t bytes, int flags, int64_t ret) "bs %p src_fd %d offset > %"PRIu64" dst_fd %d offset %"PRIu64" bytes %"PRIu64" flags %d ret %"PRId64 > > +#io_uring.c > +luring_init_state(void *s, size_t size) "s %p size %zu" > +luring_cleanup_state(void) "s freed" > +disable luring_io_plug(void) "plug" > +disable luring_io_unplug(int blocked, int plugged, int queued, int inflight) > "blocked %d plugged %d queued %d inflight %d" > +disable luring_do_submit(int blocked, int plugged, int queued, int inflight) > "blocked %d plugged %d queued %d inflight %d" > +disable luring_do_submit_done(int ret) "submitted to kernel %d" Why are these disabled? "disable" compiles them out and they won't be available at runtime. "disable" should probably be dropped here. Please include the LuringState *s pointer in trace events since there can be multiple LuringStates at any given time and it should be possible to correlate trace events.
signature.asc
Description: PGP signature
