On Tue, Jun 11, 2019 at 03:36:53PM +0800, Fam Zheng wrote:
> On Mon, 06/10 19:18, Aarushi Mehta wrote:
> > Option only enumerates for hosts that support it.
> >
> > Signed-off-by: Aarushi Mehta <mehta.aar...@gmail.com>
> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
> > ---
> > qapi/block-core.json | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/block-core.json b/qapi/block-core.json
> > index 1defcde048..db7eedd058 100644
> > --- a/qapi/block-core.json
> > +++ b/qapi/block-core.json
> > @@ -2792,11 +2792,13 @@
> > #
> > # @threads: Use qemu's thread pool
> > # @native: Use native AIO backend (only Linux and Windows)
> > +# @io_uring: Use linux io_uring (since 4.1)
> > #
> > # Since: 2.9
> > ##
> > { 'enum': 'BlockdevAioOptions',
> > - 'data': [ 'threads', 'native' ] }
> > + 'data': [ 'threads', 'native',
> > + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' }
> > ] }
>
> Question: 'native' has a dependency on libaio but it doesn't have the
> condition. Is the inconsistency intended?'native' could be conditional too but I guess it's a historical thing. Either QAPI 'if' didn't exit when BlockdevAioOptions was defined or we simply forgot to use it :). It doesn't need to be changed in this patch series. Stefan
signature.asc
Description: PGP signature
