Patchew URL: https://patchew.org/QEMU/20190605213654.9785-1-ptosc...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190605213654.9785-1-ptosc...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' abef817 ssh: switch from libssh2 to libssh === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #68: FILE: block/ssh.c:46: +/* TRACE_LIBSSH=<level> enables tracing in libssh itself. WARNING: Block comments use a leading /* on a separate line #95: FILE: block/ssh.c:64: + /* File attributes at open. We try to keep the .size field WARNING: Block comments use a leading /* on a separate line #484: FILE: block/ssh.c:491: + /* Try to authenticate with publickey, using the ssh-agent WARNING: Block comments use a leading /* on a separate line #553: FILE: block/ssh.c:662: + /* Try to disable the Nagle algorithm on TCP sockets to reduce latency, WARNING: Block comments use a leading /* on a separate line #575: FILE: block/ssh.c:679: + /* Make sure we are in blocking mode during the connection and WARNING: Block comments use a leading /* on a separate line #895: FILE: block/ssh.c:1062: + /* The size of SFTP packets is limited to 32K bytes, so limit WARNING: line over 80 characters #947: FILE: block/ssh.c:1135: + trace_ssh_write_buf(buf, end_of_vec - buf, MIN(end_of_vec - buf, 131072)); WARNING: Block comments use a leading /* on a separate line #948: FILE: block/ssh.c:1136: + /* Avoid too large data packets, as libssh currently does not ERROR: Hex numbers must be prefixed with '0x' #1122: FILE: block/trace-events:185: +ssh_auth_methods(int methods) "auth methods=%x" total: 1 errors, 8 warnings, 1175 lines checked Commit abef817e4e8f (ssh: switch from libssh2 to libssh) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190605213654.9785-1-ptosc...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
