Patchew URL: https://patchew.org/QEMU/20190602110903.3431-1-mark.cave-ayl...@ilande.co.uk/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/15] target/ppc: remove getVSR()/putVSR() and further tidy-up Type: series Message-id: 20190602110903.3431-1-mark.cave-ayl...@ilande.co.uk === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu 60905286cb..ad88e4252f master -> master From https://github.com/patchew-project/qemu * [new tag] patchew/20190602110903.3431-1-mark.cave-ayl...@ilande.co.uk -> patchew/20190602110903.3431-1-mark.cave-ayl...@ilande.co.uk Switched to a new branch 'test' 868f640501 target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro 11658435f9 target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time e9e52e3f0a target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time 239e07a0cf target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c 6aeb8a2e36 target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c b43836d4e8 target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c 241920056a target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c 959261a074 target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c ecd519b86e target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c 62b466770b target/ppc: introduce separate generator and helper for xscvqpdp d8a5beec33 target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c b2de1761e5 target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions 895b953f81 target/ppc: remove getVSR()/putVSR() from int_helper.c ca941ffe9e target/ppc: remove getVSR()/putVSR() from mem_helper.c eae59c79c5 target/ppc: remove getVSR()/putVSR() from fpu_helper.c === OUTPUT BEGIN === 1/15 Checking commit eae59c79c5ea (target/ppc: remove getVSR()/putVSR() from fpu_helper.c) 2/15 Checking commit ca941ffe9eaf (target/ppc: remove getVSR()/putVSR() from mem_helper.c) 3/15 Checking commit 895b953f8175 (target/ppc: remove getVSR()/putVSR() from int_helper.c) 4/15 Checking commit b2de1761e581 (target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions) 5/15 Checking commit d8a5beec33bd (target/ppc: introduce GEN_VSX_HELPER_X3 macro to fpu_helper.c) 6/15 Checking commit 62b466770baa (target/ppc: introduce separate generator and helper for xscvqpdp) 7/15 Checking commit ecd519b86eec (target/ppc: introduce GEN_VSX_HELPER_X2 macro to fpu_helper.c) 8/15 Checking commit 959261a07480 (target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c) 9/15 Checking commit 241920056ab0 (target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c) 10/15 Checking commit b43836d4e8bb (target/ppc: introduce GEN_VSX_HELPER_R3 macro to fpu_helper.c) 11/15 Checking commit 6aeb8a2e36c7 (target/ppc: introduce GEN_VSX_HELPER_R2 macro to fpu_helper.c) 12/15 Checking commit 239e07a0cffa (target/ppc: introduce GEN_VSX_HELPER_R2_AB macro to fpu_helper.c) 13/15 Checking commit e9e52e3f0a39 (target/ppc: decode target register in VSX_VECTOR_LOAD_STORE_LENGTH at translation time) 14/15 Checking commit 11658435f9ff (target/ppc: decode target register in VSX_EXTRACT_INSERT at translation time) 15/15 Checking commit 868f6405015c (target/ppc: improve VSX_FMADD with new GEN_VSX_HELPER_VSX_MADD macro) WARNING: Block comments use a leading /* on a separate line #278: FILE: target/ppc/translate/vsx-impl.inc.c:1311: + /* \ WARNING: Block comments use a leading /* on a separate line #284: FILE: target/ppc/translate/vsx-impl.inc.c:1317: + /* \ ERROR: Macros with complex values should be enclosed in parenthesis #325: FILE: target/ppc/translate/vsx-ops.inc.c:66: +#define GEN_XX3FORM_NAME(name, opcname, opc2, opc3, fl2) \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 0, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 1, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 2, opc3, 0, PPC_NONE, fl2), \ +GEN_HANDLER2_E(name, opcname, 0x3C, opc2 | 3, opc3, 0, PPC_NONE, fl2) total: 1 errors, 2 warnings, 377 lines checked Patch 15/15 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190602110903.3431-1-mark.cave-ayl...@ilande.co.uk/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
