Patchew URL: https://patchew.org/QEMU/20190531134315.4109-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v16 00/23] Add RX architecture Type: series Message-id: 20190531134315.4109-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190531134315.4109-1-richard.hender...@linaro.org -> patchew/20190531134315.4109-1-richard.hender...@linaro.org Switched to a new branch 'test' ffcea440b8 target/rx: Dump bytes for each insn during disassembly d553ce4a08 target/rx: Collect all bytes during disassembly ee094326fe target/rx: Emit all disassembly in one prt() 188cad567c target/rx: Use prt_ldmi for XCHG_mr disassembly c9351a22c2 target/rx: Replace operand with prt_ldmi in disassembler 5ecb1793e3 target/rx: Disassemble rx_index_addr into a string ff68bdc506 MAINTAINERS: Add RX a4f4593c77 Add rx-softmmu c986db6ef8 hw/rx: Honor -accel qtest 1ea74258fe tests: Add rx to machine-none-test.c 4c89efca3b target/rx: Fix cpu types and names 603269c1a1 target/rx: Add RX to SysEmuTarget 02b36cecf7 target/rx: Convert to CPUClass::tlb_fill 41c99c3cc0 hw/registerfields.h: Add 8bit and 16bit register macros 31bb5f5bb7 qemu/bitops.h: Add extract8 and extract16 90429ffbcc hw/rx: RX Target hardware definition f1fc365f6c hw/char: RX62N serial communication interface (SCI) 5627ac04aa hw/timer: RX62N internal timer modules 97dafd2299 hw/intc: RX62N interrupt controller (ICUa) 662ab67e6d target/rx: RX disassembler 5e8790e8c5 target/rx: CPU definition 5113aeed41 target/rx: TCG helper 6aff3f4cc2 target/rx: TCG translation === OUTPUT BEGIN === 1/23 Checking commit 6aff3f4cc28b (target/rx: TCG translation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 total: 0 errors, 1 warnings, 3065 lines checked Patch 1/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/23 Checking commit 5113aeed4137 (target/rx: TCG helper) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 660 lines checked Patch 2/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/23 Checking commit 5e8790e8c563 (target/rx: CPU definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #14: new file mode 100644 total: 0 errors, 1 warnings, 599 lines checked Patch 3/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/23 Checking commit 662ab67e6d90 (target/rx: RX disassembler) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 1497 lines checked Patch 4/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/23 Checking commit 97dafd2299da (hw/intc: RX62N interrupt controller (ICUa)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 5/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/23 Checking commit 5627ac04aa17 (hw/timer: RX62N internal timer modules) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 total: 0 errors, 1 warnings, 839 lines checked Patch 6/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/23 Checking commit f1fc365f6ce9 (hw/char: RX62N serial communication interface (SCI)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 7/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/23 Checking commit 90429ffbcc0e (hw/rx: RX Target hardware definition) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 460 lines checked Patch 8/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/23 Checking commit 31bb5f5bb70f (qemu/bitops.h: Add extract8 and extract16) 10/23 Checking commit 41c99c3cc087 (hw/registerfields.h: Add 8bit and 16bit register macros) Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2466. ERROR: Macros with multiple statements should be enclosed in a do - while loop #25: FILE: include/hw/registerfields.h:25: +#define REG8(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) }; ERROR: Macros with multiple statements should be enclosed in a do - while loop #29: FILE: include/hw/registerfields.h:29: +#define REG16(reg, addr) \ + enum { A_ ## reg = (addr) }; \ + enum { R_ ## reg = (addr) / 2 }; total: 2 errors, 0 warnings, 56 lines checked Patch 10/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/23 Checking commit 02b36cecf78a (target/rx: Convert to CPUClass::tlb_fill) 12/23 Checking commit 603269c1a130 (target/rx: Add RX to SysEmuTarget) 13/23 Checking commit 4c89efca3b19 (target/rx: Fix cpu types and names) 14/23 Checking commit 1ea74258febe (tests: Add rx to machine-none-test.c) 15/23 Checking commit c986db6ef867 (hw/rx: Honor -accel qtest) 16/23 Checking commit a4f4593c77c7 (Add rx-softmmu) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 45 lines checked Patch 16/23 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/23 Checking commit ff68bdc50604 (MAINTAINERS: Add RX) 18/23 Checking commit 5ecb1793e39b (target/rx: Disassemble rx_index_addr into a string) 19/23 Checking commit c9351a22c284 (target/rx: Replace operand with prt_ldmi in disassembler) 20/23 Checking commit 188cad567c87 (target/rx: Use prt_ldmi for XCHG_mr disassembly) 21/23 Checking commit ee094326feba (target/rx: Emit all disassembly in one prt()) 22/23 Checking commit d553ce4a083a (target/rx: Collect all bytes during disassembly) 23/23 Checking commit ffcea440b863 (target/rx: Dump bytes for each insn during disassembly) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190531134315.4109-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
