On 5/29/19 2:51 PM, Markus Armbruster wrote: > Max Filippov <jcmvb...@gmail.com> writes: > >> On Tue, May 28, 2019 at 11:12 AM Markus Armbruster <arm...@redhat.com> wrote: >>> target/xtensa/helper.h >> Intentional. >> >>> target/xtensa/overlay_tool.h >> Unintentional. >> >>> target/xtensa/xtensa-isa.h >> It's a one-liner that includes another header. > > Feels like a bad idea, but it doesn't bother me right now.
I think include/hw/xtensa/xtensa-isa.h is misplaced, it should be in target/xtensa/xtensa-isa.h, but since disas/xtensa.c includes it, it ended in include/.