On Mon, May 27, 2019 at 01:25:56AM -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20190527080327.10780-1-mehta.aar...@gmail.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH v3 0/8] Add support for io_uring > Type: series > Message-id: 20190527080327.10780-1-mehta.aar...@gmail.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 75fc7f1 block/fileposix: extend to use io_uring > d03ae39 blockdev: accept io_uring as option > cae30ee util/async: add aio interfaces for io_uring > f3be807 stubs: add stubs for io_uring interface > 85c03de block/io_uring: implements interfaces for io_uring > 5c4a14a block/block: add BDRV flag for io_uring > 9a6594d qapi/block-core: add option for io_uring > 460c72d configure: permit use of io_uring > > === OUTPUT BEGIN === > 1/8 Checking commit 460c72d1a8df (configure: permit use of io_uring) > 2/8 Checking commit 9a6594daa76c (qapi/block-core: add option for io_uring) > 3/8 Checking commit 5c4a14a301f5 (block/block: add BDRV flag for io_uring) > 4/8 Checking commit 85c03de16186 (block/io_uring: implements interfaces for > io_uring) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #49: > new file mode 100644 > > ERROR: space required before the open parenthesis '(' > #196: FILE: block/io_uring.c:143: > + while(!s->io_q.in_queue) { > > ERROR: trailing whitespace > #209: FILE: block/io_uring.c:156: > + if (ret <= 0) { $ > > total: 2 errors, 1 warnings, 387 lines checked > > Patch 4/8 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > 5/8 Checking commit f3be80708ad1 (stubs: add stubs for io_uring interface) > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #35: > new file mode 100644 > > total: 0 errors, 1 warnings, 46 lines checked > > Patch 5/8 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 6/8 Checking commit cae30ee1388f (util/async: add aio interfaces for io_uring) > 7/8 Checking commit d03ae39c331c (blockdev: accept io_uring as option) > 8/8 Checking commit 75fc7f1d8a3e (block/fileposix: extend to use io_uring) > === OUTPUT END ===
Hi Aarushi, I use this git hook to identify checkpatch.pl issues at git-commit(1) time: http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html This way I don't need to resend patch series because the issues were already taken care of earlier in the development process. Stefan
signature.asc
Description: PGP signature
