Patchew URL: https://patchew.org/QEMU/20190525225013.13916-1-laur...@vivier.eu/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190525225013.13916-1-laur...@vivier.eu Type: series Subject: [Qemu-devel] [PATCH v7 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190525225013.13916-1-laur...@vivier.eu -> patchew/20190525225013.13916-1-laur...@vivier.eu Switched to a new branch 'test' f556bdda0b hw/m68k: define Macintosh Quadra 800 937de47b17 hw/m68k: add a dummy SWIM floppy controller 6c6978f083 hw/m68k: add Nubus support for macfb video card e20d403316 hw/m68k: add Nubus support 3e9f2296f1 hw/m68k: add macfb video card d1247477c0 hw/m68k: implement ADB bus support for via beee051e0f hw/m68k: add via support 48c6f3a154 dp8393x: manage big endian bus 700fe1c320 esp: add pseudo-DMA as used by Macintosh 46fe7b4c2a escc: introduce a selector for the register bit === OUTPUT BEGIN === 1/10 Checking commit 46fe7b4c2a99 (escc: introduce a selector for the register bit) 2/10 Checking commit 700fe1c32069 (esp: add pseudo-DMA as used by Macintosh) WARNING: Block comments use a leading /* on a separate line #284: FILE: hw/scsi/esp.c:351: + /* If there is still data to be read from the device then WARNING: Block comments use * on subsequent lines #285: FILE: hw/scsi/esp.c:352: + /* If there is still data to be read from the device then + complete the DMA operation immediately. Otherwise defer WARNING: Block comments use a trailing */ on a separate line #286: FILE: hw/scsi/esp.c:353: + until the scsi layer has completed. */ total: 0 errors, 3 warnings, 452 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit 48c6f3a1541d (dp8393x: manage big endian bus) 4/10 Checking commit beee051e0f54 (hw/m68k: add via support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #91: FILE: hw/misc/mac_via.c:48: +#define VIA1A_vSccWrReq 0x80 /* SCC write. (input) WARNING: Block comments use a leading /* on a separate line #98: FILE: hw/misc/mac_via.c:55: +#define VIA1A_vRev8 0x40 /* Revision 8 board ??? WARNING: Block comments use a leading /* on a separate line #108: FILE: hw/misc/mac_via.c:65: +#define VIA1A_vHeadSel 0x20 /* Head select for IWM. WARNING: Block comments use a leading /* on a separate line #113: FILE: hw/misc/mac_via.c:70: +#define VIA1A_vOverlay 0x10 /* [Macintosh Family] On SE/30,II,IIx,IIcx WARNING: Block comments use a leading /* on a separate line #127: FILE: hw/misc/mac_via.c:84: +#define VIA1A_vSync 0x08 /* [CHRP] Sync Modem: modem clock select: WARNING: Block comments use a leading /* on a separate line #135: FILE: hw/misc/mac_via.c:92: +/* Macintosh Family Hardware sez: bits 0-2 of VIA1A are volume control WARNING: Block comments use a leading /* on a separate line #150: FILE: hw/misc/mac_via.c:107: +/* Info on VIA1B is from Macintosh Family Hardware & MkLinux. WARNING: Block comments use a trailing */ on a separate line #151: FILE: hw/misc/mac_via.c:108: + * CHRP offers no info. */ WARNING: Block comments use a leading /* on a separate line #152: FILE: hw/misc/mac_via.c:109: +#define VIA1B_vSound 0x80 /* Sound enable (for compatibility with WARNING: Block comments use a trailing */ on a separate line #155: FILE: hw/misc/mac_via.c:112: + * 0=error, 1=OK. */ WARNING: Block comments use a leading /* on a separate line #156: FILE: hw/misc/mac_via.c:113: +#define VIA1B_vMystery 0x40 /* On IIci, parity enable. 0=enabled,1=disabled WARNING: Block comments use a trailing */ on a separate line #159: FILE: hw/misc/mac_via.c:116: + * as a slot $E interrupt. */ WARNING: Block comments use a leading /* on a separate line #186: FILE: hw/misc/mac_via.c:143: +/* RAM size bits decoded as follows: WARNING: Block comments use a leading /* on a separate line #198: FILE: hw/misc/mac_via.c:155: +#define VIA2B_vVBL 0x80 /* VBL output to VIA1 (60.15Hz) driven by WARNING: Block comments use a trailing */ on a separate line #201: FILE: hw/misc/mac_via.c:158: + * [MkLinux] RBV_PARODD: 1=odd,0=even. */ WARNING: Block comments use a leading /* on a separate line #202: FILE: hw/misc/mac_via.c:159: +#define VIA2B_vSndJck 0x40 /* External sound jack status. WARNING: Block comments use a trailing */ on a separate line #203: FILE: hw/misc/mac_via.c:160: + * 0=plug is inserted. On SE/30, always 0 */ WARNING: Block comments use a leading /* on a separate line #206: FILE: hw/misc/mac_via.c:163: +#define VIA2B_vMode32 0x08 /* 24/32bit switch - doubles as cache flush WARNING: Block comments use a leading /* on a separate line #214: FILE: hw/misc/mac_via.c:171: +#define VIA2B_vPower 0x04 /* Power off, 0=shut off power. WARNING: Block comments use a leading /* on a separate line #217: FILE: hw/misc/mac_via.c:174: +#define VIA2B_vBusLk 0x02 /* Lock NuBus transactions, 0=locked. WARNING: Block comments use a leading /* on a separate line #220: FILE: hw/misc/mac_via.c:177: +#define VIA2B_vCDis 0x01 /* Cache control. On IIci, 1=disable cache card WARNING: Block comments use a leading /* on a separate line #234: FILE: hw/misc/mac_via.c:191: +/* Apple sez: http://developer.apple.com/technotes/ov/ov_04.html WARNING: Block comments use a leading /* on a separate line #263: FILE: hw/misc/mac_via.c:220: + /* CHRP sez never ever to *write* this. WARNING: Block comments use a leading /* on a separate line #279: FILE: hw/misc/mac_via.c:236: +/* Apple Macintosh Family Hardware Refenece ERROR: space prohibited after that '&&' (ctx:WxW) #361: FILE: hw/misc/mac_via.c:318: + if (!(v1s->last_b & VIA1B_vRTCClk) && (s->b & VIA1B_vRTCClk)) { ^ total: 1 errors, 25 warnings, 788 lines checked Patch 4/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/10 Checking commit d1247477c045 (hw/m68k: implement ADB bus support for via) 6/10 Checking commit 3e9f2296f16e (hw/m68k: add macfb video card) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #53: new file mode 100644 total: 0 errors, 1 warnings, 502 lines checked Patch 6/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/10 Checking commit e20d40331612 (hw/m68k: add Nubus support) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 total: 0 errors, 1 warnings, 518 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit 6c6978f083af (hw/m68k: add Nubus support for macfb video card) 9/10 Checking commit 937de47b17b1 (hw/m68k: add a dummy SWIM floppy controller) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #233: FILE: hw/block/swim.c:192: + /* rerror/werror aren't supported by fdc and therefore not even registered WARNING: Block comments use a trailing */ on a separate line #235: FILE: hw/block/swim.c:194: + * blkconf_apply_backend_options(). */ WARNING: Block comments use a leading /* on a separate line #245: FILE: hw/block/swim.c:204: + /* 'enospc' is the default for -drive, 'report' is what blk_new() gives us WARNING: Block comments use a trailing */ on a separate line #246: FILE: hw/block/swim.c:205: + * for empty drives. */ total: 0 errors, 5 warnings, 504 lines checked Patch 9/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/10 Checking commit f556bdda0b87 (hw/m68k: define Macintosh Quadra 800) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #95: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #274: FILE: hw/m68k/q800.c:69: +/* the video base, whereas it a Nubus address, WARNING: Block comments use a leading /* on a separate line #387: FILE: hw/m68k/q800.c:182: + /* MacSonic driver needs an Apple MAC address total: 0 errors, 3 warnings, 511 lines checked Patch 10/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190525225013.13916-1-laur...@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
