On Fri, May 24, 2019 at 07:33:29PM +0530, Aarushi Mehta wrote: > Signed-off-by: Aarushi Mehta <mehta.aar...@gmail.com> > --- > qapi/block-core.json | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 7ccbfff9d0..0e927b247d 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -2776,11 +2776,13 @@ > # > # @threads: Use qemu's thread pool > # @native: Use native AIO backend (only Linux and Windows) > +# @io_uring: Use linux io_uring (only Linux) > # > -# Since: 2.9 > +# Since: 4.1
Please leave "Since: 2.9" unchanged and mark only @io_uring "Since:
4.1". This way users can see that this specific option was added in
4.1 and the rest has been available since 2.9.
> ##
> { 'enum': 'BlockdevAioOptions',
> - 'data': [ 'threads', 'native' ] }
> + 'data': [ 'threads', 'native',
> + { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX)' } ] }
What about CONFIG_LINUX_IO_URING? That way the feature wouldn't be
advertized on Linux systems that don't offer io_uring.
Note that in order to do this you'll need to move the ./configure
patches before this patch (or squash them into this patch).
signature.asc
Description: PGP signature
