On 22/05/2019 07:10, David Gibson wrote: > On Wed, May 22, 2019 at 05:37:47AM +0100, Mark Cave-Ayland wrote: >> On 22/05/2019 01:49, David Gibson wrote: >> >>> On Wed, May 22, 2019 at 06:11:12AM +1000, Anton Blanchard wrote: >>>> Hi, >>>> >>>>> I've now had a bit of time to look through this and I believe it is >>>>> correct, so: >>>>> >>>>> Reviewed-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk> >>>> >>>> Thanks Mark. David: any chance we could get this merged? I can't run a >>>> recent Ubuntu image successfully without it. sshd hangs when I try to >>>> ssh into it. >>> >>> I had a comment that was never addressed - it didn't look like the xth >>> and xtl temporaries were initialized after the patch. >> >> If it helps, here was my analysis at the time (looks like you were also >> included on >> the reply?): >> https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg01515.html. > > Sorry, I missed that. Looks reasonable, I think I failed to spot the > generated load instructions which effectively initialize the temps. > > This is all at some remove now, can you resend the patch on top of the > latest tree please and I'll apply. It's missed the pull request I > sent today, obviously, but I know I have some other stuff I want to > get in pretty soon, so I expect to send another one relatively soon.
All done - I've just sent a v2 rebased upon your ppc-for-4.1 branch with R-B and T-B tags included. ATB, Mark.
