On 14/05/2019 12.08, Peter Maydell wrote: > On Tue, 14 May 2019 at 11:02, Thomas Huth <th...@redhat.com> wrote: >> >> The device is only used by certain Arm boards. Now that we have >> fine-grained Kconfig for these machines, too, we can enable the >> "unimplemented" devices only for the machines that really need it. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> hw/arm/Kconfig | 9 +++++++++ >> hw/microblaze/Kconfig | 1 + >> hw/misc/Kconfig | 3 +++ >> hw/misc/Makefile.objs | 2 +- >> hw/sparc64/Kconfig | 1 + >> 5 files changed, 15 insertions(+), 1 deletion(-) > > Commit message says "only Arm" but code change changes > sparc and microblaze Kconfigs too :-)
D'oh! ... I started with grep'ing for TYPE_UNIMPLEMENTED_DEVICE and only saw Arm boards there. When I tested my patches, I noticed that I must also add the machines that use the create_unimplemented_device() function, but apparently forgot to fix up the commit message accordingly. I'll fix it in v2. Thomas
