On May 10, 2019 10:36 PM, "Richard Henderson" <richard.hender...@linaro.org> wrote: > > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the > dependencies that check it out are associated with softmmu, > which then generates a build error on slirp/ not present. >
Hi, Does this work if only user mode targets are specified via ˊ--target-listˊ switch? If no, the patch shoud be amended. If yes, the commit message should be extended. Thanks, Aleksandar > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > configure | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure b/configure > index 63f312bd1f..9de7e43a80 100755 > --- a/configure > +++ b/configure > @@ -5878,6 +5878,10 @@ fi > ########################################## > # check for slirp > > +if test "$softmmu" = "no"; then > + slirp=no > +fi > + > case "$slirp" in > "" | yes) > if $pkg_config slirp; then > -- > 2.17.1 > >
