On Thu, May 09, 2019 at 03:57:24PM +0800, Hou Qiming wrote: > Pulled back the `qemu_create_displaysurface_guestmem` function to create > the display surface so that the guest memory gets properly unmaped. > > Signed-off-by: HOU Qiming <hqm03s...@gmail.com> > --- > hw/display/ramfb.c | 53 ++++++++++++++++++++++++++++++++++++---------- > 1 file changed, 42 insertions(+), 11 deletions(-) > > diff --git a/hw/display/ramfb.c b/hw/display/ramfb.c > index 25c8ad7..c27fcc7 100644 > --- a/hw/display/ramfb.c > +++ b/hw/display/ramfb.c > @@ -29,13 +29,50 @@ struct QEMU_PACKED RAMFBCfg { > struct RAMFBState { > DisplaySurface *ds; > uint32_t width, height; > + hwaddr addr, length;
Why do you add these? Seem not to be used anywhere in the patch ... Also a more descriptive subject line would be good. cheers, Gerd