On Sat, Apr 16, 2011 at 10:42 AM, Adam Lackorzynski <a...@os.inf.tu-dresden.de> wrote: > > On Fri Apr 15, 2011 at 15:17:28 +0200, Kevin Wolf wrote: >> Am 15.04.2011 09:56, schrieb Adam Lackorzynski: >> > Support quoting of ',' (and '\') to allow commas in the parameter list of >> > modules. >> > >> > Signed-off-by: Adam Lackorzynski <a...@os.inf.tu-dresden.de> >> >> Other options in qemu use double commas for escaping. So maybe reusing >> get_opt_value() would make things more consistent. It also has the >> advantage that double commas don't need additional escape characters for >> the shell. >> >> On the other hand, using backslashes for escaping is probably more >> familiar for most people, so I don't have a very strong opinion on it. > > Same for me. I like the fact with the double-commas and easier shell > quoting. On the other side using backslashes is more common. However, I > construct the overall command via scripts anyway, so I'll only very > seldom actually type this myself. > > Here's how it would look like. Diff is smaller. > More opinions very welcome.
I like this more because it is more consistent with QEMU syntax and reuses code. Stefan
