On Tue, May 07, 2019 at 10:11:02AM +0200, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 5/7/19 9:54 AM, Gerd Hoffmann wrote: > > On Fri, Apr 12, 2019 at 01:16:26PM +0100, Daniel P. Berrangé wrote: > >> The SPICE_RING_PROD_ITEM() macro is initializing a local > >> 'uint64_t *' variable to point to the 'el' field inside > >> the QXLReleaseRing struct. This uint64_t field is not > >> guaranteed aligned as the struct is packed. > >> > >> Code should not take the address of fields within a > >> packed struct. Changing the SPICE_RING_PROD_ITEM() > >> macro to avoid taking the address of the field is > >> impractical. It is clearer to just remove the macro > >> and inline its functionality in the three call sites > >> that need it. > > > > Added patch to vga queue. > > What about the other patch Marc-André sent? > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg01318.html
Other patch version for the same issue, we need only one of the two. cheers, Gerd
