On 5/4/19 4:09 PM, Thomas Huth wrote: > On 04/05/2019 14.35, Philippe Mathieu-Daudé wrote: >> The ne2000.c file contains functions common the the ISA and PCI >> devices. To allow to build with one or another, extract the PCI >> specific part into a new file. >> >> This fix an issue where the NE2000_ISA Kconfig had to pull the >> full PCI core objects. >> >> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> --- >> hw/net/Kconfig | 7 ++- >> hw/net/Makefile.objs | 3 +- >> hw/net/ne2000-pci.c | 132 +++++++++++++++++++++++++++++++++++++++++++ >> hw/net/ne2000.c | 105 ---------------------------------- >> 4 files changed, 139 insertions(+), 108 deletions(-) >> create mode 100644 hw/net/ne2000-pci.c >> >> diff --git a/hw/net/Kconfig b/hw/net/Kconfig >> index 7d7bbc5d7c9..4ef86dc3a53 100644 >> --- a/hw/net/Kconfig >> +++ b/hw/net/Kconfig >> @@ -1,10 +1,14 @@ >> config DP8393X >> bool >> >> +config NE2000_COMMON >> + bool > > I'd maybe rather simply name it "NE2000" instead of "NE2000_COMMON", but > that's just a matter of taste.
I started using this name, but then realized it is confuse and someone could enable CONFIG_NE2000=y expecting a network device, but none would be linked. Paolo, would it be useful to add some 'internal' Kconfig property (like "default")? So that config is not user-selectable, but only dependency-selectable. CONFIG_ARM_V7M might be a similar example (we don't want the user to unselect it). > > Reviewed-by: Thomas Huth <th...@redhat.com> Thanks!
