On 13 April 2011 21:38, Stefan Weil <w...@mail.berlios.de> wrote: > gen_pc_load was introduced in commit > d2856f1ad4c259e5766847c49acbb4e390731bd4. > The only reason for parameter searched_pc was > a debug statement in target-i386/translate.c. > > Remove searched_pc from the debug statement > and from the parameter list of gen_pc_load.
No issues with the meat of the patch, but if we're going to change all the callers and implementations of this anyway, is there any appetite for giving it a more appropriate name? It doesn't generate any code, it affects more than just the pc, and it doesn't do a load... restore_state_to_opc() ? set_env_for_opc() ? -- PMM
