Aurelien Jarno writes: > On Wed, Apr 13, 2011 at 06:16:55PM +0100, Peter Maydell wrote: >> On 13 April 2011 17:38, Lluís <xscr...@gmx.net> wrote: >> > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> >> > --- >> > target-arm/helper.c | 246 >> > ++++++++++++++++++++++---------------------- >> > target-arm/iwmmxt_helper.c | 28 +++-- >> > target-arm/translate.c | 26 ++--- >> > 3 files changed, 150 insertions(+), 150 deletions(-) >> >> My preference is not to do large-scale whitespace changes >> unless the code's being touched in that area anyway, so >> I'd prefer this not to be applied. >> >> (They make things painful for forks and branches, and >> they make git blame less useful; disadvantages outweigh >> the minor benefits of the cleanup IMHO.) >>
> I agree that this patch should not be applied. BTW, the next patch applies nicely without this one, so I'm assuming you don't need me to re-send anything. Lluis -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
