On 4/22/19 5:42 AM, Chen Zhang via Qemu-devel wrote:
> In target/i386/hvf/hvf.c, a break statement was probably missing in
> `hvf_vcpu_exec()`, in handling EXIT_REASON_HLT.
>
> These lines seemed to be equivalent to `kvm_handle_halt()`.
>
Fixes: c97d6d2cdf97
> Signed-off-by: Chen Zhang <tgfb...@me.com>
> ---
> target/i386/hvf/hvf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
> index 42f9447303..2751c8125c 100644
> --- a/target/i386/hvf/hvf.c
> +++ b/target/i386/hvf/hvf.c
> @@ -708,6 +708,7 @@ int hvf_vcpu_exec(CPUState *cpu)
> !(idtvec_info & VMCS_IDT_VEC_VALID)) {
> cpu->halted = 1;
> ret = EXCP_HLT;
> + break;
Oops... I'm surprised no compiler warned about this yet...
This probably mean:
- This code is not covered by Continuous Integration
- Upstream maintainers are not building this code
- Upstream is not running this code
Please tell me I'm wrong!
Meanwhile:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> }
> ret = EXCP_INTERRUPT;
> break;
>
