Hi Eduardo,
On 4/18/19 6:01 AM, Eduardo Habkost wrote:
> hppa_cpu_list() is dead code and is never called. Delete it.
>
> Cc: Richard Henderson <r...@twiddle.net>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> ---
> target/hppa/cpu.c | 22 ----------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
> index 00bf444620..b3b1826209 100644
> --- a/target/hppa/cpu.c
> +++ b/target/hppa/cpu.c
> @@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error
> **errp)
> #endif
> }
>
> -static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
> -{
> - ObjectClass *oc = data;
> - CPUListState *s = user_data;
> -
> - (*s->cpu_fprintf)(s->file, " %s\n", object_class_get_name(oc));
> -}
> -
> -void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
You forgot to remove the declaration in "target/hppa/cpu.h".
With this header updated:
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> -{
> - CPUListState s = {
> - .file = f,
> - .cpu_fprintf = cpu_fprintf,
> - };
> - GSList *list;
> -
> - list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
> - (*cpu_fprintf)(f, "Available CPUs:\n");
> - g_slist_foreach(list, hppa_cpu_list_entry, &s);
> - g_slist_free(list);
> -}
> -
> static void hppa_cpu_initfn(Object *obj)
> {
> CPUState *cs = CPU(obj);
>
