On 4/17/19 2:06 PM, Markus Armbruster wrote: > char_pty_open() prints a "char device redirected to PTY_NAME (label > LABEL)" message to the current monitor or else to stderr. This is not > an error, so it shouldn't go to stderr. Print it to stdout instead. > > Why is it even printed? No other ChardevClass::open() prints anything > on success. It's because you need to know PTY_NAME to actually use > this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME" > to use the monitor's readline interface. You can get PTY_NAME with > "info chardev" (a.k.a. query-chardev for QMP), but only if you already > have a monitor. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > chardev/char-pty.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
