On 4/11/19 12:08 AM, David Hildenbrand wrote: > Let's keep it simple for now and handle 8/16/128 bit elements via helpers. > Especially for 8/16, we could come up with some bit tricks. > > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > target/s390x/helper.h | 3 +++ > target/s390x/insn-data.def | 2 ++ > target/s390x/translate_vx.inc.c | 30 +++++++++++++++++++++ > target/s390x/vec_int_helper.c | 47 +++++++++++++++++++++++++++++++++ > 4 files changed, 82 insertions(+)
Similar comments to add carry, really, but what you have is not wrong. Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~