"Dr. David Alan Gilbert" <dgilb...@redhat.com> writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> dump_drift_info() takes an fprintf()-like callback and a FILE * to > > ^^^^^^^^^^^^^^^^^^^ looks like the wrong function for this patch?
Pasto, will fix. >> pass to it, and so do its helper functions. Passing around callback >> and argument is rather tiresome. >> >> Its only caller hmp_info_mtree() passes monitor_printf() cast to >> fprintf_function and the current monitor cast to FILE *. >> >> The type-punning is technically undefined behaviour, but works in >> practice. Clean up: drop the callback, and call qemu_printf() >> instead. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Other than the function name above, > > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Thanks!
