On Thu, Apr 11, 2019 at 16:52:44 +0200, Markus Armbruster wrote:
> char_pty_open() prints a "char device redirected to PTY_NAME (label
> LABEL)" message to the current monitor or else to stderr. No other
> ChardevClass::open() prints anything on success. Drop the message.
>
> Cc: "Marc-André Lureau" <marcandre.lur...@redhat.com>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> chardev/char-pty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/chardev/char-pty.c b/chardev/char-pty.c
> index b034332edd..a48d3e5d20 100644
> --- a/chardev/char-pty.c
> +++ b/chardev/char-pty.c
> @@ -211,8 +211,6 @@ static void char_pty_open(Chardev *chr,
> qemu_set_nonblock(master_fd);
>
> chr->filename = g_strdup_printf("pty:%s", pty_name);
> - error_printf("char device redirected to %s (label %s)\n",
> - pty_name, chr->label);Don't be scared by the one occurence of this string in a 'strstr' call in libvirt. We thankfully deleted the code that was using it to extract the PTY path a long time ago. The only leftover part is to skip it when we are attempting to extract an useful error from qemu which would be reported to stderr prior to initiating QMP so getting rid of the message actually has no effect. https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=932534e85f34a479c7eac174e997bfd9c85bd22d
signature.asc
Description: PGP signature
