On Wed 10 Apr 2019 06:29:18 PM CEST, Max Reitz wrote: > # Reopen an image several times changing some of its options > def test_reopen(self): > + # Check whether the filesystem supports O_DIRECT > + if 'O_DIRECT' in qemu_io('-f', 'raw', '-t', 'none', '-c', 'quit', > hd_path[0]): > + supports_direct = False > + else: > + supports_direct = True
I don't see any other test needing this at the moment (at least none written in Python), but I wonder if this is something worth having in iotests.py. The patch looks fine anyway. Reviewed-by: Alberto Garcia <be...@igalia.com> Berto