On Wed, 10 Apr 2019 at 22:51, Andrew Randrianasulu <randrianas...@gmail.com> wrote: > > Please also include this patch in next -rc or final, it fixes 32-bit > compilation: > > https://patchew.org/QEMU/20190402073018.17747-1-kraxel%40redhat.com/ > ([Qemu-devel] [PATCH] curses: fix wchar_t printf warning) > > without it I get > > ui/curses.c: In function 'get_ucs': > ui/curses.c:456:25: error: format '%x' expects argument of type 'unsigned > int', but argument 3 has type 'wchar_t {aka long int}' [-Werror=format=] > fprintf(stderr, "Could not convert 0x%02x from WCHAR_T to UCS-2: > %s\n", >
Rats, I'd forgotten about that one. What platform does it fail to compile on, though? I test on 32-bit Linux and Windows compiles, and they work OK. Also, this will be only a warning, not a compile error, in the release build, so we could get away with releasing without the patch applied. We'll see if any other rc4 issues come up. thanks -- PMM
