On 4/5/19 1:14 PM, Philippe Mathieu-Daudé wrote:
> On 4/5/19 12:59 PM, Olaf Hering wrote:
>> Am Fri, 5 Apr 2019 12:49:15 +0200
>> schrieb Philippe Mathieu-Daudé <phi...@redhat.com>:
>>
>>> The EDK2 submodule was added for UEFI testing, you don't need to compile
>>> it to build/use QEMU.
>>>
>>> How did you end up compiling it?
>>
>> The qemu.spec file has this since a very long time:
>> make -C roms efirom ${unrelated_settings}
>
> I don't have any qemu.spec, is it a SUSE file?I checked and apparently. >> >> This used to work still in January with >> c9d18c1c150c84e7a976df989ad04ddf01083f46. > > Before f590a812c210 the EfiRom tool was not available, now we compile it > inconditionally. > > So I assume your distribution already provides the EfiRom tool. Can you > point me at the package which provides it? I wonder if your distribution > use a non-upstreamed patch that change the EDK2 BaseTools PIE/PIC flags. I see EfiRom was previously provided by ovmf-tools-2017.src.rpm, and the latest ovmf-2019.src.rpm has this file: $ cat ovmf-pie.patch Index: ovmf-2018+git1534736099.43fe4c405292/BaseTools/Source/C/Makefiles/header.makefile =================================================================== --- ovmf-2018+git1534736099.43fe4c405292.orig/BaseTools/Source/C/Makefiles/header.makefile +++ ovmf-2018+git1534736099.43fe4c405292/BaseTools/Source/C/Makefiles/header.makefile @@ -77,7 +77,7 @@ ifeq ($(DARWIN),Darwin) # assume clang or clang compatible flags on OS X BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign -Wno-unused-result -nostdlib -g else -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation -Wno-restrict -Wno-unused-result -nostdlib -g -fPIE endif BUILD_LFLAGS = BUILD_CXXFLAGS = -Wno-unused-result
signature.asc
Description: OpenPGP digital signature
