On 4/1/19 2:58 AM, Peter Maydell wrote: > On Sat, 30 Mar 2019 at 22:05, Eric Blake <ebl...@redhat.com> wrote: >> Rich told me that qemu-nbd.8 was not being built, and I confirmed that >> it failed to build for me. git bisect points to this commit as the >> reason that 'touch qemu-nbd.texi; make' no longer rebuilds qemu-nbd.8 >> automatically. Is it merely because I don't have enough stuff installed, >> or is it an actual broken dependency? >> >> /me goes and runs 'dnf install "*/sphinx-build"... >> >> Nope, even with that installed, qemu-nbd.8 is still not getting built by >> 'make'; but 'make qemu-nbd.8' is working. We lost a dependency :( > > I just did a test build from clean and I get a qemu-nbd.8 in the > build directory. I also checked that 'touch qemu-nbd.texi; make -C build V=1' > rebuilds the manpage, and it does: > > [snip other stuff] > perl -Ww -- /home/pm215/qemu/scripts/texi2pod.pl -I docs -I > /home/pm215/qemu -I . "-DVERSION=3.1.91" > /home/pm215/qemu/qemu-nbd.texi qemu-nbd.8.pod && pod2man --utf8 > --section=8 --center=" " --release=" " qemu-nbd.8.pod > qemu-nbd.8 > [...] > > You will need sphinx-build in order to build > the docs now, and without that we won't build the manpage, but > if you have sphinx-build installed then it should work. > Can you check that your config-host.mak has BUILD_DOCS=yes ?
Not seeing it. > Did you definitely rerun configure after installing sphinx? Trying that again. I did not specify anything special to configure to force-enable/disable docs, so this time, it should auto-detect that sphinx-build is present... and now BUILD_DOCS=yes appears... And that fixes it. Thanks for helping me spot the added build dependency. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
