Re: [Qemu-devel] [PATCH 1/3] util: add a space before an open parenthesis to fix checkpatch errors

[Thomas Huth]

On 29/03/2019 16.08, Jules Irenge wrote:
> Add a space before open parenthesis to fix errors issued by checkpatch.pl
> "ERROR: space required before the open parenthesis"
>  within "util/readline.c" file.
> 
> Signed-off-by: Jules Irenge <jbi.oct...@gmail.com>
> ---
>  util/readline.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/util/readline.c b/util/readline.c
> index ec91ee0fea..a97b600428 100644
> --- a/util/readline.c
> +++ b/util/readline.c
> @@ -48,13 +48,13 @@ static void readline_update(ReadLineState *rs)
>  
>      if (rs->cmd_buf_size != rs->last_cmd_buf_size ||
>          memcmp(rs->cmd_buf, rs->last_cmd_buf, rs->cmd_buf_size) != 0) {
> -        for(i = 0; i < rs->last_cmd_buf_index; i++) {
> +        for (i = 0; i < rs->last_cmd_buf_index; i++) {
>              rs->printf_func(rs->opaque, "\033[D");
>          }
>          rs->cmd_buf[rs->cmd_buf_size] = '\0';
>          if (rs->read_password) {
>              len = strlen(rs->cmd_buf);
> -            for(i = 0; i < len; i++)
> +            for (i = 0; i < len; i++)
>                  rs->printf_func(rs->opaque, "*");

While you're at it, could you please also add curly braces for this
for-loop? ... that's mandated by the QEMU coding conventions, too.

And since there is no explicit maintainer for the util folder and this
is a straight forward clean-up, please also put qemu-triv...@nongnu.org
on CC: when you send the next iteration - that should help to get these
patches merged more easily.

 Thanks,
  Thomas