On 07.04.2011, at 20:22, Adam Lackorzynski wrote:
> Quote filename in error message to spot possible whitespace character in
> the filename.
>
> Signed-off-by: Adam Lackorzynski <a...@os.inf.tu-dresden.de>
> ---
> hw/multiboot.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 0d2bfb4..6be6fa0 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -272,7 +272,7 @@ int load_multiboot(void *fw_cfg,
> mb_debug("multiboot loading module: %s\n", initrd_filename);
> mb_mod_length = get_image_size(initrd_filename);
> if (mb_mod_length < 0) {
> - fprintf(stderr, "failed to get %s image size\n",
> initrd_filename);
> + fprintf(stderr, "failed to get image size of '%s'\n",
> initrd_filename);
I'd like to see something telling the user that the most likely reason is that
the file isn't there :). It might even make sense to only say "Failed to open
file '%s'".
Alex
