Patchew URL: https://patchew.org/QEMU/20190322001544.9794-1-da...@gibson.dropbear.id.au/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190322001544.9794-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [RFC for-4.1 00/25] Many style fixes for target/ppc Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190321144914.19934-1-...@kaod.org -> patchew/20190321144914.19934-1-...@kaod.org * [new tag] patchew/20190322001544.9794-1-da...@gibson.dropbear.id.au -> patchew/20190322001544.9794-1-da...@gibson.dropbear.id.au Switched to a new branch 'test' d9a6215ecc target/ppc: Style fixes for translate/spe-impl.inc.c 65eb138512 target/ppc: Style fixes for translate/vmx-impl.inc.c 8d94edbb00 target/ppc: Style fixes for translate/vsx-impl.inc.c 3caa9d49eb target/ppc: Style fixes for translate/fp-impl.inc.c 101d9580ee target/ppc: Style fixes for translate.c 461682526f target/ppc: Style fixes for translate_init.inc.c 4aeb580b71 target/ppc: Style fixes for monitor.c 364bed3f12 target/ppc: Style fixes for mmu_helper.c a2f32fdcab target/ppc: Style fixes for mmu-hash64.[ch] d52341d796 target/ppc: Style fixes for mmu-hash32.[ch] 465ef88fa6 target/ppc: Style fixes for misc_helper.c cf4f0dde0d target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c 6b40470682 target/ppc: Style fixes for mem_helper.c 197f1940be target/ppc: Style fixes for machine.c cc497c316b target/ppc: Style fixes for kvm_ppc.h and kvm.c 62ba6a3440 target/ppc: Style fixes for helper_regs.h a1eb273604 target/ppc: Style fixes for gdbstub.c 2731feaffd target/ppc: Style fixes for excp_helper.c 7061f73523 target/ppc: Style fixes for dfp_helper.c 07ce42ad0f target/ppc: Style fixes for fpu_helper.c c4b4fbf526 target/ppc: Style fixes for int_helper.c 6a09c460c6 target/ppc: Style fixes for cpu.[ch] d60f69cf64 target/ppc: Style fixes for ppc-models.[ch] 0b955f8caf hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h" c57df151ad spapr: Support NVIDIA V100 GPU with NVLink2 === OUTPUT BEGIN === 1/25 Checking commit c57df151ad04 (spapr: Support NVIDIA V100 GPU with NVLink2) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #258: new file mode 100644 total: 0 errors, 1 warnings, 877 lines checked Patch 1/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/25 Checking commit 0b955f8caf6d (hw/ppc/prep: Drop useless inclusion of "hw/input/i8042.h") 3/25 Checking commit d60f69cf648e (target/ppc: Style fixes for ppc-models.[ch]) 4/25 Checking commit 6a09c460c6d7 (target/ppc: Style fixes for cpu.[ch]) 5/25 Checking commit c4b4fbf52642 (target/ppc: Style fixes for int_helper.c) 6/25 Checking commit 07ce42ad0f3b (target/ppc: Style fixes for fpu_helper.c) WARNING: Block comments use a leading /* on a separate line #129: FILE: target/ppc/fpu_helper.c:2229: + /* \ WARNING: Block comments use a leading /* on a separate line #158: FILE: target/ppc/fpu_helper.c:2286: + /* \ WARNING: Block comments use a leading /* on a separate line #181: FILE: target/ppc/fpu_helper.c:2340: + /* \ WARNING: Block comments use a leading /* on a separate line #351: FILE: target/ppc/fpu_helper.c:3182: + /* \ total: 0 errors, 4 warnings, 328 lines checked Patch 6/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/25 Checking commit 7061f73523cd (target/ppc: Style fixes for dfp_helper.c) ERROR: spaces required around that '+' (ctx:VxV) #35: FILE: target/ppc/dfp_helper.c:1119: + decNumberSetBCD(&dfp.t, digits+((size) / 4) - n, n); \ ^ total: 1 errors, 0 warnings, 39 lines checked Patch 7/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/25 Checking commit 2731feaffd29 (target/ppc: Style fixes for excp_helper.c) 9/25 Checking commit a1eb273604e4 (target/ppc: Style fixes for gdbstub.c) 10/25 Checking commit 62ba6a34409b (target/ppc: Style fixes for helper_regs.h) 11/25 Checking commit cc497c316b30 (target/ppc: Style fixes for kvm_ppc.h and kvm.c) WARNING: line over 80 characters #440: FILE: target/ppc/kvm.c:2719: + ((qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - starttime) < max_ns))); total: 0 errors, 1 warnings, 423 lines checked Patch 11/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/25 Checking commit 197f1940bef9 (target/ppc: Style fixes for machine.c) 13/25 Checking commit 6b40470682e6 (target/ppc: Style fixes for mem_helper.c) 14/25 Checking commit cf4f0dde0d44 (target/ppc: Style fixes for mfrom_table.inc.c & mfrom_table_gen.c) 15/25 Checking commit 465ef88fa68e (target/ppc: Style fixes for misc_helper.c) 16/25 Checking commit d52341d79675 (target/ppc: Style fixes for mmu-hash32.[ch]) 17/25 Checking commit a2f32fdcab89 (target/ppc: Style fixes for mmu-hash64.[ch]) 18/25 Checking commit 364bed3f12a8 (target/ppc: Style fixes for mmu_helper.c) 19/25 Checking commit 4aeb580b7111 (target/ppc: Style fixes for monitor.c) 20/25 Checking commit 461682526fa3 (target/ppc: Style fixes for translate_init.inc.c) 21/25 Checking commit 101d9580ee2c (target/ppc: Style fixes for translate.c) WARNING: Block comments use a leading /* on a separate line #34: FILE: target/ppc/translate.c:59: + + 8 * 5 /* CRF */]; WARNING: Block comments use a leading /* on a separate line #1244: FILE: target/ppc/translate.c:6701: + /* \ WARNING: Block comments use a leading /* on a separate line #1266: FILE: target/ppc/translate.c:6727: + /* \ WARNING: Block comments use a leading /* on a separate line #1298: FILE: target/ppc/translate.c:6770: + /* \ total: 0 errors, 4 warnings, 1332 lines checked Patch 21/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/25 Checking commit 3caa9d49ebcd (target/ppc: Style fixes for translate/fp-impl.inc.c) 23/25 Checking commit 8d94edbb0049 (target/ppc: Style fixes for translate/vsx-impl.inc.c) WARNING: Block comments use a leading /* on a separate line #73: FILE: target/ppc/translate/vsx-impl.inc.c:1447: + /* \ total: 0 errors, 1 warnings, 57 lines checked Patch 23/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/25 Checking commit 65eb1385127c (target/ppc: Style fixes for translate/vmx-impl.inc.c) WARNING: Block comments use a leading /* on a separate line #29: FILE: target/ppc/translate/vmx-impl.inc.c:31: + /* \ WARNING: Block comments use a leading /* on a separate line #42: FILE: target/ppc/translate/vmx-impl.inc.c:66: + /* \ total: 0 errors, 2 warnings, 75 lines checked Patch 24/25 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/25 Checking commit d9a6215eccb6 (target/ppc: Style fixes for translate/spe-impl.inc.c) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190322001544.9794-1-da...@gibson.dropbear.id.au/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com