On 3/20/19 7:27 AM, Yoshinori Sato wrote: > Hi. > I found some problem in tested RX instructions. > It is usable in RX instructions, but I think that there > is a better fix because I am not familiar with Python.
The patch itself look ok, but needs some changes. > I fixed three point. > - Added ctx to !function args. This seems fine. But it needs either (1) A command-line option, or (2) Changes to all existing users in the tree. Otherwise the build breaks for the other targets. > - Fixed group operaiton. varinsns required width field. > - Fixed symbol in decode_load_bytes args. Thanks. I can fold these fixes into v2 of the varinsns patches. r~
