On 07.04.2011, at 02:19, r...@humppa.name wrote:
> Multiboot modules couldn't be loaded when there are spaces between the
> filename and ','. Those spaces can simply be killed.
>
> Signed-off-by:
> ---
> diff --git a/hw/multiboot.c b/hw/multiboot.c
> index 0d2bfb4..27eb159 100644
> --- a/hw/multiboot.c
> +++ b/hw/multiboot.c
> @@ -267,6 +267,9 @@ int load_multiboot(void *fw_cfg,
> /* if a space comes after the module filename, treat everything
> after that as parameters */
> target_phys_addr_t c = mb_add_cmdline(&mbs, initrd_filename);
> + /* Kill spaces at the beginning of the filename */
> + while( *initrd_filename == ' ' )
> + initrd_filename++;
Please make sure to follow the coding style. There shouldn't be whitespace
between the (), but between while and ( and you need some extra braces :):
while (*initrd_filename == ' ') {
initrd_filename++;
}
Otherwise, the patch looks good! Please resend a corrected version, so that it
can be easily applied.
Alex
