Le lundi 04 avril 2011 à 12:09 +0100, Peter Maydell a écrit :
> CPU_QuadU isn't used on all targets, but there's no harm in defining the
> typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because
> softfloat-native doesn't have a float128 type. This avoids the need for
> every new target which uses CPU_QuadU to add itself to an #ifdef in
> what ought to be target-agnostic code.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> Noticed this one as a result of the s390 support patches; seems like
> a minor but worthwhile cleanup to me...
Sorry for the late comment, but I saw this rebasing my patchset on
master...
> cpu-all.h | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/cpu-all.h b/cpu-all.h
> index 4cc445f..dc0f2f0 100644
> --- a/cpu-all.h
> +++ b/cpu-all.h
> @@ -138,11 +138,10 @@ typedef union {
> uint64_t ll;
> } CPU_DoubleU;
>
> -#if defined(TARGET_SPARC) || defined(TARGET_S390X)
> +#if defined(CONFIG_SOFTFLOAT)
Why don't you use "#if defined(FLOAT128)" ?
> typedef union {
> float128 q;
> -#if defined(HOST_WORDS_BIGENDIAN) \
> - || (defined(__arm__) && !defined(__VFP_FP__) &&
> !defined(CONFIG_SOFTFLOAT))
> +#if defined(HOST_WORDS_BIGENDIAN)
> struct {
> uint32_t upmost;
> uint32_t upper;
--
--------------------- laur...@vivier.eu ----------------------
"Tout ce qui est impossible reste à accomplir" Jules Verne
"Things are only impossible until they're not" Jean-Luc Picard
