On 3/13/19 11:28 AM, Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes, with the changes > to the following files manually reverted:
Is it worth tweaking scripts/clean-includes as a pre-req patch so that some of these files become listed exceptions and don't need manual reversion here? > > contrib/libvhost-user/libvhost-user-glib.h > contrib/libvhost-user/libvhost-user.c > contrib/libvhost-user/libvhost-user.h > linux-user/mips64/cpu_loop.c > linux-user/mips64/signal.c > linux-user/sparc64/cpu_loop.c > linux-user/sparc64/signal.c > linux-user/x86_64/cpu_loop.c > linux-user/x86_64/signal.c > slirp/src/* > target/s390x/gen-features.c > tests/migration/s390x/a-b-bios.c > tests/test-rcu-simpleq.c > tests/test-rcu-tailq.c > tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c > > We're in the process of spinning out slirp/. tests/uefi-test-tools/ > is guest software. The remaining reverts are the same as in commit > b7d89466dde. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > +++ b/contrib/elf2dmp/pdb.c > @@ -18,9 +18,8 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA Unrelated, but if someone is looking for a project, cleaning up stale address references in older GPL copy-and-paste is a possibility. I think these changes are okay for 4.0 soft freeze; but it also doesn't hurt if this delays into 4.1. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
