On Mon, 11 Mar 2019 11:21:30 -0400
"Jason J. Herne" <jjhe...@linux.ibm.com> wrote:
> Now that we have a Channel I/O library let's modify virtio boot code to
> make use of it for running channel programs.
>
> Signed-off-by: Jason J. Herne <jjhe...@linux.ibm.com>
> ---
> pc-bios/s390-ccw/virtio.c | 49
> +++++++++++++++++++----------------------------
> 1 file changed, 20 insertions(+), 29 deletions(-)
>
(...)
> @@ -324,7 +314,8 @@ bool virtio_is_supported(SubChannelId schid)
> vdev.schid = schid;
> memset(&vdev.senseid, 0, sizeof(vdev.senseid));
> /* run sense id command */
Maybe add a comment?
/*
* The size of the senseid data differs between devices (notably,
* between virtio devices and dasds), so specify the largest possible
* size and suppress the incorrect length indication for smaller sizes.
*/
Just in case we scratch our heads next year :)
> - if (run_ccw(&vdev, CCW_CMD_SENSE_ID, &vdev.senseid,
> sizeof(vdev.senseid))) {
> + if (run_ccw(&vdev, CCW_CMD_SENSE_ID, &vdev.senseid, sizeof(vdev.senseid),
> + true)) {
> return false;
> }
> if (vdev.senseid.cu_type == 0x3832) {
Otherwise,
Reviewed-by: Cornelia Huck <coh...@redhat.com>
