On Tue, 12 Mar 2019 at 19:00, Bandan Das <b...@redhat.com> wrote: > > > Spotted by Coverity: CID 1399414 > > mtp delete allows the return status of delete succeeded, > partial_delete or readonly - when none of the objects could be > deleted. Give more meaningful names to return values of the > delete function. > > Some initiators recurse over the objects themselves. In that case, > only READ_ONLY can be returned. > > Signed-off-by: Bandan Das <b...@redhat.com> > --- > v3: > fix typo > use g_assert_not_reached > v2: > Change the enum variable names and specify them as bits > Add a comment describing the bit definitions > Modify commit message slightly > > hw/usb/dev-mtp.c | 62 ++++++++++++++++++++++++++---------------------- > 1 file changed, 34 insertions(+), 28 deletions(-) >
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> (PS: if somebody says "[comments]. Otherwise Reviewed-by: <whoever>" they mean that if you fix the minor stuff they mention you can add their reviewed-by tag to the respin of the patchset when you send it out.) thanks -- PMM
