On Tue, 12 Mar 2019 08:11:43 -0400 Cleber Rosa <cr...@redhat.com> wrote:
> The set_console() utility function either adds a device based on the > explicitly given device type, or adds a known good type of device > based on the machine type. > > But, for a number of machine types, it may be impossible or > inconvenient to add the devices by means of "-device" command line > options, and then it may better to just use the "-serial" option and > let QEMU itself, based on the machine type, set the device > accordingly. > > To achieve that, the behavior of set_console() now flags the intention > to add a console device on launch(), and if no explicit device type is > given the "-serial" is going to be added to the QEMU command line, s/the "-serial"/the "-serial" option/ > instead of raising exceptions. > > Based on testing with different machine types, the CONSOLE_DEV_TYPES > is not necessary anymore, so it's being removed, as it is the logic to s/as it is/as is/ > use it. > > Signed-off-by: Cleber Rosa <cr...@redhat.com> > --- > python/qemu/__init__.py | 48 ++++++++++++++--------------------------- > 1 file changed, 16 insertions(+), 32 deletions(-) > Reviewed-by: Cornelia Huck <coh...@redhat.com>
