On 3/8/19 9:00 PM, Laszlo Ersek wrote: > On 03/08/19 19:07, Philippe Mathieu-Daudé wrote: >> On 3/8/19 6:31 PM, Eric Blake wrote: >>> On 3/8/19 5:08 AM, Philippe Mathieu-Daudé wrote: >>>>>> +## >>>>>> +# @query-fw_cfg-items: >>>>> >>>>> That looks weird to mix - and _. Any reason we can't just go with >>>>> query-firmware-config? >>>> >>>> Way better! I'll use query-firmware-config-items. >>> >>> Do we need the -items suffix? Also, is there a chance that we might ever >>> want to extend the command to return more information that is global to >>> firmware-config rather than per-item? >> >> Laszlo suggested it could be useful to ask for a specific item (with the >> full data encoded?). > > It's possible I referred to that a long time ago, but most recently, I > think it has been raised by Dave.
One of your 'random' ideas :) https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg01959.html (6) If we want bells and whistles, two optional parameters could be considered: one for identifying one specific key to request info about (identify by selector? well-known macro name? file pathname?), and another param for placing a limit, different from 8, on the individual hexdump size. Important: these are not "requirements", just random ideas, food for thought. I'm fine if you reject any subset of them, after consideration. > > Thanks > Laszlo
