On 3 April 2011 16:12, Aurelien Jarno <aurel...@aurel32.net> wrote: > On Sun, Apr 03, 2011 at 12:21:49PM +0100, Peter Maydell wrote: >> Anyway, how about I do a version of this patch which moves >> the affected neon helpers to op_helper.c rather than adding >> an env parameter
>> Then I can do a separate patchset to move other helpers, >> rather than tangling a code-cleanup patchset with Neon >> correctness fixes. > This solution looks fine for me. That said, I am not sure moving > everything to op_helper.c is the best solution. I would rather go for > compiling *_helper.c with HELPER_CFLAGS, which avoids having one big > file which is messy to edit, and long to compile. That sounds better, actually, and avoids moving too much code around. Still leaves the choice of: * move VFP helpers from target-arm/helper.c to another file * compile all target-*/helper.c with HELPER_CFLAGS * arm-specific exception in Makefile.target of which I'll go for option 1. -- PMM
