> > From: Markus Armbruster <arm...@redhat.com>
> > Subject: Re: [Qemu-devel] [PATCH 1/5] hw/mips/malta: Fix the
> > DEBUG_BOARD_INIT code
> >
> > Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> >
> > > Commit fa1d36df746 missed to convert this ifdef'ed out code.
> > > Introduce the pflash_blk variable.
> > >
> > > This fixes:
> > >
> > > hw/mips/mips_malta.c:1273:16: error: implicit declaration of function
> > > ‘blk_name’; > did you mean ‘basename’?
> > > [-Werror=implicit-function-declaration]
> > > blk_name(dinfo->bdrv), fl_sectors);
> > > ^~~~~~~~
> > > hw/mips/mips_malta.c:1273:16: error: nested extern declaration of
> > > ‘blk_name’
> [-Werror=nested-externs]
> > > hw/mips/mips_malta.c:1273:30: error: ‘DriveInfo’ {aka ‘struct
> > > DriveInfo’} has no
> member named ‘bdrv’
> > > blk_name(dinfo->bdrv), fl_sectors);
> > > ^~
> > >
> > > Fixes: fa1d36df746
> > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> >
> > Question for the maintainers: Aurelien, Aleksandar, fix the
> > DEBUG_BOARD_INIT code or drop it? It looks rather stale...
>
> Markus,
>
> My vote is: drop it.
>
> And, Markus, yes, if you agree with any patch from this series,
> please let them all go > though your pull request.
>
> Regards,
> Aleksandar
Markus, if you decide to drop the code segment, you have my
Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com>
in advance.
I believe the whole patch series was also reviewed by Richard.
Sincerely,
Aleksandar
