On 3/7/19 6:38 AM, Alexey Kardashevskiy wrote: > On 07/03/2019 16:21, David Gibson wrote: >> The qemu coding standard is to use CamelCase for type and structure names, >> and the pseries code follows that... sort of. There are quite a lot of >> places where we bend the rules in order to preserve the capitalization of >> internal acronyms like "PHB", "TCE", "DIMM" and most commonly "sPAPR". >> >> That was a bad idea - it frequently leads to names ending up with hard to >> read clusters of capital letters, and means they don't catch the eye as >> type identifiers, which is kind of the point of the CamelCase convention in >> the first place. >> >> In short, keeping type identifiers look like CamelCase is more important >> than preserving standard capitalization of internal "words". So, this >> patch renames a heap of spapr internal type names to a more standard >> CamelCase. >> >> In addition to case changes, we also make some other identifier renames: >> VIOsPAPR* -> SpaprVio* >> The reverse word ordering was only ever used to mitigate the capital >> cluster, so revert to the natural ordering. >> VIOsPAPRVTYDevice -> SpaprVioVty >> VIOsPAPRVLANDevice -> SpaprVioVlan >> Brevity, since the "Device" didn't add useful information >> sPAPRDRConnector -> SpaprDrc >> sPAPRDRConnectorClass -> SpaprDrcClass >> Brevity, and makes it clearer this is the same thing as a "DRC" >> mentioned in many other places in the code >> >> This is 100% a mechanical search-and-replace patch. It will, however, >> conflict with essentially any and all outstanding patches touching the >> spapr code. > > > so it would be nice to have the script to fix those outstanding patches > before reposting.
What I usually do: $ sed -i 's/sPAPRDRConnectorClass/SpaprDrcClass/' \ $(git grep -l sPAPRDRConnectorClass) > > >> >> Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> >> --- >> Changes since RFC: >> * Added a number of extra renames for brevity and/or clarity >> * Fixed couple of places the new capitalization still wasn't right >>
