Philippe Mathieu-Daudé <phi...@redhat.com> writes: > Hi Aleksandar, > > On 3/6/19 7:38 AM, Aleksandar Markovic wrote: >> On Tuesday, March 5, 2019, Philippe Mathieu-Daudé <phi...@redhat.com >> <mailto:phi...@redhat.com>> wrote: >> >> Hi Markus, >> >> this is a rework of your 'mips_malta: Clean up definition of flash >> memory size somewhat' patch: >> https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07177.html >> <https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07177.html> >> >> Regards, >> >> Phil. >> >> >> Philippe, >> >> Could you summarize end-user-visible changes resulting from this series? > > Good maintainer reflex :) > > There is an end-user visible change, if he provides a file that is not > exactly 4MiB he will now get a "Malta CoreLV card expects a bios of 4MB" > error message and QEMU will exit to his shell. This change is introduced > by patch 4/5. > > Now I rather expect this series to get integrated in Markus current > work, because his subsequent patches change the PFlash API and it is > easier he takes this (to avoid merge conflicts).
Definitely. > Note: Markus series is expected to include the following patch from Alex > Bennée: "hw/block: better reporting on pflash backing file mismatch" > https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07341.html > which is a more important user visible change. I think the the changelog > can be updated once, by Markus :) Yes. > Meanwhile, if this series is taken by Markus can I have your Ack-by? > > Thanks, > > Phil.