Patchew URL: https://patchew.org/QEMU/1551723614-1823-1-git-send-email-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551723614-1823-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PULL 00/54] Kconfig conversion, excluding ARM and MIPS === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1551723614-1823-1-git-send-email-pbonz...@redhat.com -> patchew/1551723614-1823-1-git-send-email-pbonz...@redhat.com Switched to a new branch 'test' 0a6e26d5e8 kconfig: add documentation ea170e8fde .travis.yml: test that no-default-device builds do not regress 1b47d6119c xtensa-softmmu.mak: express dependencies with Kconfig 268226f037 unicore32-softmmu.mak: express dependencies with Kconfig 4d127f4b59 sparc64-softmmu.mak: express dependencies with Kconfig 41dc3c5a6f sparc-softmmu.mak: express dependencies with Kconfig 177ea46f90 sh4-softmmu.mak: express dependencies with Kconfig bfbd16edaa s390x: express dependencies with Kconfig 0da98e9d99 riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives 2bd6d98ea7 or1k-softmmu.mak: express dependencies with Kconfig 7ad0eeb7de nios2-softmmu.mak: express dependencies with Kconfig d8036ee7a8 moxie-softmmu.mak: express dependencies with Kconfig c23e77f5aa microblaze-softmmu.mak: express dependencies with Kconfig c1a098f358 m68k-softmmu.mak: express dependencies with Kconfig 0a0ad1fa60 lm32-softmmu.mak: express dependencies with Kconfig 963592bc4d hppa-softmmu.mak: express dependencies with Kconfig 3d236ef789 cris-softmmu.mak: express dependencies with Kconfig dcd0d9418c alpha-softmmu.mak: express dependencies with Kconfig 34f29f98a6 ppc: Express dependencies of the embedded machines with kconfig a8403b6d98 ppc: Express dependencies of the Sam460EX machines with kconfig c9a90ef24e ppc: Express dependencies of the Mac machines with kconfig 31419b35d4 ppc: Express dependencies of the 'prep' and '40p' machines with kconfig 58d83d1eea ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig 8f91d4bfd3 i386-softmmu.mak: remove all CONFIG_* except boards definitions cbf73d8f0c ipmi: express dependencies with kconfig 0dd5fb4d6b sd: express dependencies with kconfig 97325e396a ssi: express dependencies with kconfig 332ad30853 isa: express SuperIO dependencies with Kconfig 6fec955cb3 tpm: express dependencies with Kconfig 45011d7502 virtio: express virtio dependencies with Kconfig a88bb8c5c0 vfio: express vfio dependencies with Kconfig 8ca215b85e hyperv: express dependencies with kconfig 0463805988 display: express dependencies with kconfig 460da886d6 ptimer: express dependencies with Kconfig 6803092964 i2c: express dependencies with Kconfig 0cc4ae9ed0 i386: express dependencies with Kconfig 0c0f46ceb9 build: convert usb.mak to Kconfig 6937417da4 scsi: express dependencies with Kconfig cc59241507 build: convert sound.mak to Kconfig be2d02caf9 build: convert pci.mak to Kconfig 7951601a63 isa: express dependencies with kconfig 409dbbb6f2 hw/pci/Makefile.objs: make pcie configurable a071d6e98d ide: express dependencies with Kconfig 7f5fdbf41d kconfig: introduce CONFIG_TEST_DEVICES da6052b249 minikconfig: implement allnoconfig and defconfig modes e8c2768dce build: switch to Kconfig f83935e733 kconfig: introduce kconfig files 1f5dc409bc hw/display: make edid configurable fe7e0fba75 minikconfig: add semantic analysis c8f1845c7c minikconfig: add AST 194871c17a minikconfig: add parser skeleton e8f333426c xtensa: rename CONFIG_XTENSA_FPGA to CONFIG_XTENSA_XTFPGA 8f50814206 9pfs: remove unnecessary conditionals 5deb877614 block: fix recursion in hw/block/dataplane === OUTPUT BEGIN === 1/54 Checking commit 5deb87761401 (block: fix recursion in hw/block/dataplane) 2/54 Checking commit 8f5081420656 (9pfs: remove unnecessary conditionals) 3/54 Checking commit e8f333426ca5 (xtensa: rename CONFIG_XTENSA_FPGA to CONFIG_XTENSA_XTFPGA) 4/54 Checking commit 194871c17a47 (minikconfig: add parser skeleton) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 WARNING: line over 80 characters #259: FILE: scripts/minikconf.py:220: + 'Expected identifier starting with "CONFIG_"', TOK_NONE) WARNING: line over 80 characters #358: FILE: scripts/minikconf.py:319: + raise KconfigParserError(self, 'expected "source", "config", identifier, ' WARNING: line over 80 characters #384: FILE: scripts/minikconf.py:345: + raise KconfigParserError(self, 'expected "source", "config" or identifier') ERROR: line over 90 characters #409: FILE: scripts/minikconf.py:370: + if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|': WARNING: line over 80 characters #464: FILE: scripts/minikconf.py:425: + while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_': total: 1 errors, 5 warnings, 441 lines checked Patch 4/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/54 Checking commit c8f1845c7c37 (minikconfig: add AST) WARNING: line over 80 characters #89: FILE: scripts/minikconf.py:90: + return "config %s default %s if %s" % (self.dest, value, self.cond) total: 0 errors, 1 warnings, 177 lines checked Patch 5/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/54 Checking commit fe7e0fba7561 (minikconfig: add semantic analysis) ERROR: line over 90 characters #125: FILE: scripts/minikconf.py:110: + raise KconfigDataError('contradiction between clauses when setting %s' % self) WARNING: line over 80 characters #228: FILE: scripts/minikconf.py:222: + debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing]) total: 1 errors, 1 warnings, 247 lines checked Patch 6/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/54 Checking commit 1f5dc409bcc9 (hw/display: make edid configurable) 8/54 Checking commit f83935e733c1 (kconfig: introduce kconfig files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100644 WARNING: line over 80 characters #1757: FILE: scripts/minikconf.py:657: + print ("%s: at least one argument is required" % argv[0], file=sys.stderr) total: 0 errors, 2 warnings, 1358 lines checked Patch 8/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/54 Checking commit e8c2768dce92 (build: switch to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #553: deleted file mode 100644 total: 0 errors, 1 warnings, 374 lines checked Patch 9/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/54 Checking commit da6052b24922 (minikconfig: implement allnoconfig and defconfig modes) 11/54 Checking commit 7f5fdbf41dc2 (kconfig: introduce CONFIG_TEST_DEVICES) 12/54 Checking commit a071d6e98d83 (ide: express dependencies with Kconfig) 13/54 Checking commit 409dbbb6f21d (hw/pci/Makefile.objs: make pcie configurable) 14/54 Checking commit 7951601a6310 (isa: express dependencies with kconfig) 15/54 Checking commit be2d02caf9a3 (build: convert pci.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #145: deleted file mode 100644 total: 0 errors, 1 warnings, 493 lines checked Patch 15/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/54 Checking commit cc59241507f0 (build: convert sound.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #68: deleted file mode 100644 total: 0 errors, 1 warnings, 49 lines checked Patch 16/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/54 Checking commit 6937417da4f9 (scsi: express dependencies with Kconfig) 18/54 Checking commit 0c0f46ceb9fe (build: convert usb.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #158: deleted file mode 100644 total: 0 errors, 1 warnings, 167 lines checked Patch 18/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 19/54 Checking commit 0cc4ae9ed023 (i386: express dependencies with Kconfig) 20/54 Checking commit 6803092964f0 (i2c: express dependencies with Kconfig) 21/54 Checking commit 460da886d636 (ptimer: express dependencies with Kconfig) 22/54 Checking commit 0463805988e4 (display: express dependencies with kconfig) 23/54 Checking commit 8ca215b85e92 (hyperv: express dependencies with kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: deleted file mode 100644 total: 0 errors, 1 warnings, 11 lines checked Patch 23/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 24/54 Checking commit a88bb8c5c0ca (vfio: express vfio dependencies with Kconfig) 25/54 Checking commit 45011d750284 (virtio: express virtio dependencies with Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: deleted file mode 100644 total: 0 errors, 1 warnings, 97 lines checked Patch 25/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/54 Checking commit 6fec955cb359 (tpm: express dependencies with Kconfig) 27/54 Checking commit 332ad3085359 (isa: express SuperIO dependencies with Kconfig) 28/54 Checking commit 97325e396a0b (ssi: express dependencies with kconfig) 29/54 Checking commit 0dd5fb4d6b3d (sd: express dependencies with kconfig) 30/54 Checking commit cbf73d8f0c30 (ipmi: express dependencies with kconfig) 31/54 Checking commit 8f91d4bfd333 (i386-softmmu.mak: remove all CONFIG_* except boards definitions) 32/54 Checking commit 58d83d1eea52 (ppc64: Express dependencies of 'pseries' and 'powernv' machines with kconfig) 33/54 Checking commit 31419b35d46a (ppc: Express dependencies of the 'prep' and '40p' machines with kconfig) 34/54 Checking commit c9a90ef24eb7 (ppc: Express dependencies of the Mac machines with kconfig) 35/54 Checking commit a8403b6d98a8 (ppc: Express dependencies of the Sam460EX machines with kconfig) 36/54 Checking commit 34f29f98a676 (ppc: Express dependencies of the embedded machines with kconfig) 37/54 Checking commit dcd0d9418ca0 (alpha-softmmu.mak: express dependencies with Kconfig) 38/54 Checking commit 3d236ef7896f (cris-softmmu.mak: express dependencies with Kconfig) 39/54 Checking commit 963592bc4d8b (hppa-softmmu.mak: express dependencies with Kconfig) 40/54 Checking commit 0a0ad1fa605c (lm32-softmmu.mak: express dependencies with Kconfig) 41/54 Checking commit c1a098f35829 (m68k-softmmu.mak: express dependencies with Kconfig) 42/54 Checking commit c23e77f5aa26 (microblaze-softmmu.mak: express dependencies with Kconfig) 43/54 Checking commit d8036ee7a82a (moxie-softmmu.mak: express dependencies with Kconfig) 44/54 Checking commit 7ad0eeb7dead (nios2-softmmu.mak: express dependencies with Kconfig) 45/54 Checking commit 2bd6d98ea7c8 (or1k-softmmu.mak: express dependencies with Kconfig) 46/54 Checking commit 0da98e9d9936 (riscv-softmmu.mak: replace CONFIG_* with Kconfig "select" directives) 47/54 Checking commit bfbd16edaa98 (s390x: express dependencies with Kconfig) 48/54 Checking commit 177ea46f90b8 (sh4-softmmu.mak: express dependencies with Kconfig) 49/54 Checking commit 41dc3c5a6ff6 (sparc-softmmu.mak: express dependencies with Kconfig) 50/54 Checking commit 4d127f4b59e5 (sparc64-softmmu.mak: express dependencies with Kconfig) 51/54 Checking commit 268226f03725 (unicore32-softmmu.mak: express dependencies with Kconfig) 52/54 Checking commit 1b47d6119c83 (xtensa-softmmu.mak: express dependencies with Kconfig) 53/54 Checking commit ea170e8fde6a (.travis.yml: test that no-default-device builds do not regress) 54/54 Checking commit 0a6e26d5e85b (kconfig: add documentation) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100644 total: 0 errors, 1 warnings, 305 lines checked Patch 54/54 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551723614-1823-1-git-send-email-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com