On 3/3/19 1:46 PM, BALATON Zoltan wrote: > On Sun, 3 Mar 2019, Philippe Mathieu-Daudé wrote: >> Hi Zoltan, >> >> On 3/3/19 12:34 AM, BALATON Zoltan wrote: >>> At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI >>> gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and >>> guests running on these and the PMON2000 firmware of the fulong2e >>> expect this to be available. Fortunately these are very similar chips >>> so they can be mostly emulated in the same device model. This patch >>> adds basic emulation of these ATI VGA chips. >>> >>> While this is incomplete and currently only enough to run the MIPS >>> firmware and get framebuffer output with Linux, it allows the fulong2e >>> board to work more like the real hardware and having it in QEMU in >>> this state provides a way to experiment with it and allows others to >>> contribute to improve it. It is compiled for all archs but only the >>> fulong2e (which currently has no display output at all) is set to use >>> it by default (in a patch sent separately). >> >> Patch looks good, trivial comment inlined. > > Hello, > Thanks for yhe review. I took what I liked, [...]
So for your next version: Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
