Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 0ccb36bdb9 target/riscv: Remaining rvc insn reuse 32 bit translators c8844da104 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 9d9d15f5ad target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 bde8dff68c target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns a0edcbd157 target/riscv: Convert @cs_2 insns to share translation functions 6fb54c8cf3 target/riscv: Remove decode_RV32_64G() 9b1d307737 target/riscv: Remove gen_system() 9921d33bdd target/riscv: Rename trans_arith to gen_arith 0e9bfc6cfc target/riscv: Remove manual decoding of RV32/64M insn f61e83b050 target/riscv: Remove shift and slt insn manual decoding 027416235e target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists f89cdc4840 target/riscv: Move gen_arith_imm() decoding into trans_* functions 98995c5d08 target/riscv: Remove manual decoding from gen_store() 472ff95917 target/riscv: Remove manual decoding from gen_load() 1f64ddc61b target/riscv: Remove manual decoding from gen_branch() 1cec38c6a3 target/riscv: Remove gen_jalr() ce449e7757 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 5947da36b5 target/riscv: Convert quadrant 1 of RVXC insns to decodetree e78b74569a target/riscv: Convert quadrant 0 of RVXC insns to decodetree d26e158770 target/riscv: Convert RV priv insns to decodetree fa243130cb target/riscv: Convert RV64D insns to decodetree dbf2aedfb4 target/riscv: Convert RV32D insns to decodetree 44962a0e7b target/riscv: Convert RV64F insns to decodetree 78cfbc497e target/riscv: Convert RV32F insns to decodetree 8c1b94f60a target/riscv: Convert RV64A insns to decodetree 96aa55ec50 target/riscv: Convert RV32A insns to decodetree 8baecc31e5 target/riscv: Convert RVXM insns to decodetree 014292da10 target/riscv: Convert RVXI csr insns to decodetree 5fd757167d target/riscv: Convert RVXI fence insns to decodetree f972af043f target/riscv: Convert RVXI arithmetic insns to decodetree 5346012bb0 target/riscv: Convert RV64I load/store insns to decodetree a2ffd12b79 target/riscv: Convert RV32I load/store insns to decodetree 32d890482d target/riscv: Convert RVXI branch insns to decodetree 44f86f707d target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 44f86f707d0a (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 32d890482d81 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit a2ffd12b7936 (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit 5346012bb075 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit f972af043f14 (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 5fd757167d13 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 014292da100c (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 8baecc31e54d (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 96aa55ec5028 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 8c1b94f60aeb (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 78cfbc497e5c (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 44962a0e7b1d (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit dbf2aedfb4b6 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit fa243130cbf1 (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit d26e15877013 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit e78b74569ab6 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 5947da36b5f5 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit ce449e7757eb (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 1cec38c6a3ac (target/riscv: Remove gen_jalr()) 20/34 Checking commit 1f64ddc61b2b (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 472ff95917fd (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit 98995c5d0806 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit f89cdc4840d0 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 027416235e39 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit f61e83b05074 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 0e9bfc6cfc7c (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit 9921d33bdd07 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 9b1d307737a5 (target/riscv: Remove gen_system()) 29/34 Checking commit 6fb54c8cf38f (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit a0edcbd157bd (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit bde8dff68cc6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 9d9d15f5ad23 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit c8844da104be (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 0ccb36bdb9f6 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
