Patchew URL: https://patchew.org/QEMU/1550677216-5077-1-git-send-email-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1550677216-5077-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] chardev-socket: do not blindly reset handlers when switching GMainContext Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3b90d7e1d7 chardev-socket: do not blindly reset handlers when switching GMainContext === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #102: FILE: tests/test-char.c:1071: + /* Start a second connection while the first is still connected. ERROR: code indent should never use tabs #136: FILE: tests/test-char.c:1441: +^I^I char_socket_server_two_clients_test);$ ERROR: code indent should never use tabs #138: FILE: tests/test-char.c:1443: +^I^I char_socket_server_two_clients_test);$ total: 2 errors, 1 warnings, 115 lines checked Commit 3b90d7e1d778 (chardev-socket: do not blindly reset handlers when switching GMainContext) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1550677216-5077-1-git-send-email-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com