Patchew URL: https://patchew.org/QEMU/1550908162-22644-1-git-send-email-th...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1550908162-22644-1-git-send-email-th...@redhat.com Subject: [Qemu-devel] [PATCH v3 00/30] Kconfig dependencies for ARM machines Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190225152053.15976-1-kw...@redhat.com -> patchew/20190225152053.15976-1-kw...@redhat.com Switched to a new branch 'test' b67b22dc6c hw/arm: Remove hard-enablement of the remaining PCI devices b497bb3e9c hw/arm: Express dependencies of the musca machines with Kconfig 99016ce233 hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig c4392f1604 hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig 774a7c0779 hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig d89c7bb60e hw/arm: Express dependencies for remaining IMX boards with Kconfig 4178bc31f5 hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig 9bed49be32 hw/arm: Express dependencies of sabrelite with Kconfig 90d591b964 hw/arm: Express dependencies of canon-a1100 with Kconfig 8712c95f6d hw/arm: Express dependencies of the raspi machines with Kconfig 2a9b18ae2c hw/arm: Express dependencies of the MPS2 boards with Kconfig f76db015a9 hw/arm: Express dependencies of allwinner / cubieboard with Kconfig 507511f8f4 hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig 995af0d76f hw/arm: Express dependencies of the virt machine with Kconfig b2a62e980c hw/arm: Express dependencies of the aspeed boards with Kconfig 6cff6e6c80 hw/arm: Express dependencies of collie with Kconfig 9f7a125715 hw/arm: Express dependencies of xilinx-zynq with Kconfig 1243291e61 hw/arm: Express dependencies of the PXA2xx machines with Kconfig f6fb8381ae hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig d420180364 hw/arm: Express dependencies of stellaris with Kconfig 75693d2a8a hw/arm: Express dependencies of the OMAP machines with Kconfig 3c4fad8c83 hw/arm: Express dependencies of musicpal with Kconfig f75d8142b3 hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig d7263e3d0a hw/arm: Express dependencies of integratorcp with Kconfig 9049bc8c84 hw/arm: Express dependencies of the highbank machines with Kconfig 85a66fbdbe hw/arm: Express dependencies of the exynos machines with Kconfig 1cea7d9d48 hw/sd/sdhci: Move PCI-related code into a separate file 78e45dde97 hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device 2a03982a2d hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs 1f80397aba hw/arm/Kconfig: Add a config switch for MUSCA === OUTPUT BEGIN === 1/30 Checking commit 1f80397aba15 (hw/arm/Kconfig: Add a config switch for MUSCA) 2/30 Checking commit 2a03982a2d49 (hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs) 3/30 Checking commit 78e45dde97af (hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device) 4/30 Checking commit 1cea7d9d4898 (hw/sd/sdhci: Move PCI-related code into a separate file) ERROR: Macros with complex values should be enclosed in parenthesis #76: FILE: hw/sd/sdhci-internal.h:326: +#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \ + DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \ + DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \ + \ + /* Capabilities registers provide information on supported WARNING: Block comments use a leading /* on a separate line #80: FILE: hw/sd/sdhci-internal.h:330: + /* Capabilities registers provide information on supported WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #93: new file mode 100644 total: 1 errors, 2 warnings, 290 lines checked Patch 4/30 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/30 Checking commit 85a66fbdbe78 (hw/arm: Express dependencies of the exynos machines with Kconfig) 6/30 Checking commit 9049bc8c8431 (hw/arm: Express dependencies of the highbank machines with Kconfig) 7/30 Checking commit d7263e3d0a14 (hw/arm: Express dependencies of integratorcp with Kconfig) 8/30 Checking commit f75d8142b37f (hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig) 9/30 Checking commit 3c4fad8c83d2 (hw/arm: Express dependencies of musicpal with Kconfig) 10/30 Checking commit 75693d2a8a4f (hw/arm: Express dependencies of the OMAP machines with Kconfig) 11/30 Checking commit d4201803642c (hw/arm: Express dependencies of stellaris with Kconfig) 12/30 Checking commit f6fb8381ae31 (hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig) 13/30 Checking commit 1243291e616c (hw/arm: Express dependencies of the PXA2xx machines with Kconfig) 14/30 Checking commit 9f7a12571562 (hw/arm: Express dependencies of xilinx-zynq with Kconfig) 15/30 Checking commit 6cff6e6c80d0 (hw/arm: Express dependencies of collie with Kconfig) 16/30 Checking commit b2a62e980c5b (hw/arm: Express dependencies of the aspeed boards with Kconfig) 17/30 Checking commit 995af0d76fec (hw/arm: Express dependencies of the virt machine with Kconfig) 18/30 Checking commit 507511f8f499 (hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig) 19/30 Checking commit f76db015a955 (hw/arm: Express dependencies of allwinner / cubieboard with Kconfig) 20/30 Checking commit 2a9b18ae2c8e (hw/arm: Express dependencies of the MPS2 boards with Kconfig) 21/30 Checking commit 8712c95f6d95 (hw/arm: Express dependencies of the raspi machines with Kconfig) 22/30 Checking commit 90d591b96428 (hw/arm: Express dependencies of canon-a1100 with Kconfig) 23/30 Checking commit 9bed49be323f (hw/arm: Express dependencies of sabrelite with Kconfig) 24/30 Checking commit 4178bc31f518 (hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig) 25/30 Checking commit d89c7bb60eaa (hw/arm: Express dependencies for remaining IMX boards with Kconfig) 26/30 Checking commit 774a7c077939 (hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig) 27/30 Checking commit c4392f1604eb (hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig) 28/30 Checking commit 99016ce2339d (hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig) 29/30 Checking commit b497bb3e9cd8 (hw/arm: Express dependencies of the musca machines with Kconfig) 30/30 Checking commit b67b22dc6c03 (hw/arm: Remove hard-enablement of the remaining PCI devices) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1550908162-22644-1-git-send-email-th...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com