Patchew URL:
https://patchew.org/QEMU/20190215174548.2630-1-yury-ko...@yandex-team.ru/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190215174548.2630-1-yury-ko...@yandex-team.ru
Subject: [Qemu-devel] [PATCH v3 0/5] Add ignore-external migration capability
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
74b71b6821 migration: Add capabilities validation
6d93a8d489 tests/migration-test: Add a test for ignore-shared capability
49c2e3db2c migration: Add an ability to ignore shared RAM blocks
96e230b463 migration: Introduce ignore-shared capability
c56095df53 exec: Change RAMBlockIterFunc definition
=== OUTPUT BEGIN ===
1/5 Checking commit c56095df53b1 (exec: Change RAMBlockIterFunc definition)
2/5 Checking commit 96e230b46352 (migration: Introduce ignore-shared capability)
3/5 Checking commit 49c2e3db2cab (migration: Add an ability to ignore shared
RAM blocks)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#147: FILE: migration/ram.c:169:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block) \
+ INTERNAL_RAMBLOCK_FOREACH(block) \
+ if (ramblock_is_ignored(block)) {} else
ERROR: trailing statements should be on next line
#149: FILE: migration/ram.c:171:
+ if (ramblock_is_ignored(block)) {} else
total: 2 errors, 0 warnings, 386 lines checked
Patch 3/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 6d93a8d48994 (tests/migration-test: Add a test for
ignore-shared capability)
5/5 Checking commit 74b71b6821b2 (migration: Add capabilities validation)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190215174548.2630-1-yury-ko...@yandex-team.ru/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
